fix: While a text event starts which changes the portrait, the new character portrait scene is created after the signal text_started is emited#2678
Open
cliveglitch wants to merge 1 commit into
Conversation
…e info Dictionary will return the outdated portrait info instead of the latest
cliveglitch
changed the title
Member
|
Thanks! It makes sense, but I will have to test this a bit before I feel comfortable, the text event is so damn finicky, reordering/retiming things like this usually mess something up 😭. |
Contributor
Author
|
I understand, I don't know if there's a way in gdscript to await the portrait changes just before emitting the signals, kinda like using Javascript Promises, you run them and save the promise in a variable and await it when you need it... that could be an alternative if it breaks something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix just awaits the change_speaker and change_character_portrait calls so it instantiates the new character portrait scene before the calling the text_started and about_to_show_text signals.
I think it makes more sense if when changing the portrait, the latest portrait character scene is there to receive the signal.